Bläddra i källkod

Remove test of httpurlconnection implementation detail (#5670)

Anuraag Agrawal 3 år sedan
förälder
incheckning
854f3eb3dc

+ 0 - 6
instrumentation/http-url-connection/javaagent/build.gradle.kts

@@ -7,9 +7,3 @@ muzzle {
     coreJdk()
   }
 }
-
-tasks.withType<Test>().configureEach {
-  // required on jdk17
-  jvmArgs("--add-opens=java.base/sun.net.www.protocol.https=ALL-UNNAMED")
-  jvmArgs("-XX:+IgnoreUnrecognizedVMOptions")
-}

+ 0 - 12
instrumentation/http-url-connection/javaagent/src/test/groovy/HttpUrlConnectionTest.groovy

@@ -7,9 +7,7 @@ import io.opentelemetry.api.trace.Span
 import io.opentelemetry.instrumentation.test.AgentTestTrait
 import io.opentelemetry.instrumentation.test.base.HttpClientTest
 import io.opentelemetry.semconv.trace.attributes.SemanticAttributes
-import spock.lang.Requires
 import spock.lang.Unroll
-import sun.net.www.protocol.https.HttpsURLConnectionImpl
 
 import static io.opentelemetry.api.trace.SpanKind.CLIENT
 import static io.opentelemetry.api.trace.SpanKind.SERVER
@@ -260,14 +258,4 @@ class HttpUrlConnectionTest extends HttpClientTest<HttpURLConnection> implements
       }
     }
   }
-
-  // This test makes no sense on IBM JVM because there is no HttpsURLConnectionImpl class there
-  @Requires({ !System.getProperty("java.vm.name").contains("IBM J9 VM") })
-  def "Make sure we can load HttpsURLConnectionImpl"() {
-    when:
-    def instance = new HttpsURLConnectionImpl(null, null, null)
-
-    then:
-    instance != null
-  }
 }