123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087 |
- // Copyright The OpenTelemetry Authors
- // SPDX-License-Identifier: Apache-2.0
- package snmpreceiver // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/snmpreceiver"
- import (
- "context"
- "errors"
- "fmt"
- "path/filepath"
- "testing"
- "github.com/stretchr/testify/mock" // client is an autogenerated mock type for the client type
- "github.com/stretchr/testify/require"
- "go.opentelemetry.io/collector/component/componenttest"
- "go.opentelemetry.io/collector/pdata/pmetric"
- "go.opentelemetry.io/collector/receiver/receivertest"
- "go.opentelemetry.io/collector/receiver/scrapererror"
- "go.uber.org/zap"
- "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/golden"
- "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatatest/pmetrictest"
- )
- type MockClient struct {
- mock.Mock
- }
- // Close provides a mock function with given fields:
- func (_m *MockClient) Close() error {
- ret := _m.Called()
- var r0 error
- if rf, ok := ret.Get(0).(func() error); ok {
- r0 = rf()
- } else {
- r0 = ret.Error(0)
- }
- return r0
- }
- // Connect provides a mock function with given fields:
- func (_m *MockClient) Connect() error {
- ret := _m.Called()
- var r0 error
- if rf, ok := ret.Get(0).(func() error); ok {
- r0 = rf()
- } else {
- r0 = ret.Error(0)
- }
- return r0
- }
- // GetIndexedData provides a mock function with given fields: oids, scraperErrors
- func (_m *MockClient) GetIndexedData(oids []string, scraperErrors *scrapererror.ScrapeErrors) []SNMPData {
- ret := _m.Called(oids, scraperErrors)
- var r0 []SNMPData
- if rf, ok := ret.Get(0).(func([]string, *scrapererror.ScrapeErrors) []SNMPData); ok {
- r0 = rf(oids, scraperErrors)
- } else if ret.Get(0) != nil {
- r0 = ret.Get(0).([]SNMPData)
- }
- return r0
- }
- // GetScalarData provides a mock function with given fields: oids, scraperErrors
- func (_m *MockClient) GetScalarData(oids []string, scraperErrors *scrapererror.ScrapeErrors) []SNMPData {
- ret := _m.Called(oids, scraperErrors)
- var r0 []SNMPData
- if rf, ok := ret.Get(0).(func([]string, *scrapererror.ScrapeErrors) []SNMPData); ok {
- r0 = rf(oids, scraperErrors)
- } else if ret.Get(0) != nil {
- r0 = ret.Get(0).([]SNMPData)
- }
- return r0
- }
- func TestStart(t *testing.T) {
- testCases := []struct {
- desc string
- testFunc func(*testing.T)
- }{
- {
- desc: "Bad Config",
- testFunc: func(t *testing.T) {
- scraper := &snmpScraper{
- cfg: &Config{},
- settings: receivertest.NewNopCreateSettings(),
- }
- err := scraper.start(context.Background(), componenttest.NewNopHost())
- require.Error(t, err)
- },
- },
- {
- desc: "Valid Config",
- testFunc: func(t *testing.T) {
- scraper := &snmpScraper{
- cfg: createDefaultConfig().(*Config),
- settings: receivertest.NewNopCreateSettings(),
- }
- err := scraper.start(context.Background(), componenttest.NewNopHost())
- require.NoError(t, err)
- },
- },
- }
- for _, tc := range testCases {
- t.Run(tc.desc, tc.testFunc)
- }
- }
- func TestScrape(t *testing.T) {
- testCases := []struct {
- desc string
- testFunc func(*testing.T)
- }{
- {
- // Config is responsible for making sure this would never happen
- desc: "No Metric Configs returns no metrics with no error",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- scraper := &snmpScraper{
- cfg: &Config{},
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- require.Equal(t, metrics.MetricCount(), 0)
- },
- },
- {
- desc: "Scalar scrape errors and no indexed metric configs adds error",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- clientErr := errors.New("problem getting scrape data")
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", mock.Anything, mock.Anything).Run(
- func(args mock.Arguments) {
- scraperErrors := args.Get(1).(*scrapererror.ScrapeErrors)
- scraperErrors.AddPartial(1, clientErr)
- },
- ).Return([]SNMPData{})
- scraper := &snmpScraper{
- cfg: &Config{
- Metrics: map[string]*MetricConfig{
- "metric1": {
- ScalarOIDs: []ScalarOID{
- {
- OID: "1",
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- metrics, err := scraper.scrape(context.Background())
- require.EqualError(t, err, clientErr.Error())
- require.Equal(t, metrics.MetricCount(), 0)
- },
- },
- {
- desc: "Scalar scrape returns string data does not create metric",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- oid := "1"
- clientSNMPData := SNMPData{
- oid: oid,
- value: "test",
- valueType: stringVal,
- }
- innerError := fmt.Errorf(errMsgBadValueType, oid)
- expectedScrapeErr := fmt.Errorf(errMsgScalarOIDProcessing, oid, innerError)
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", mock.Anything, mock.Anything).Return([]SNMPData{clientSNMPData})
- scraper := &snmpScraper{
- cfg: &Config{
- Metrics: map[string]*MetricConfig{
- "metric1": {
- ScalarOIDs: []ScalarOID{
- {
- OID: "1",
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- metrics, err := scraper.scrape(context.Background())
- require.EqualError(t, err, expectedScrapeErr.Error())
- require.Equal(t, metrics.MetricCount(), 0)
- },
- },
- {
- desc: "Simple scalar scrape creates int gauge metric (1)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- clientSNMPData := SNMPData{
- oid: ".1",
- value: int64(1),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", mock.Anything, mock.Anything).Return([]SNMPData{clientSNMPData})
- scraper := &snmpScraper{
- cfg: &Config{
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".1",
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "1_scalar_metrics_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Simple scalar scrape with non '.' prefixed OID still creates metric (1)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- clientSNMPData := SNMPData{
- oid: ".1",
- value: int64(1),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", mock.Anything, mock.Anything).Return([]SNMPData{clientSNMPData})
- scraper := &snmpScraper{
- cfg: &Config{
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: "1",
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "1_scalar_metrics_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Simple scalar scrape creates float cumulative monotonic sum metric (2)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- clientSNMPData := SNMPData{
- oid: ".1",
- value: float64(1.0),
- valueType: floatVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", mock.Anything, mock.Anything).Return([]SNMPData{clientSNMPData})
- scraper := &snmpScraper{
- cfg: &Config{
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Sum: &SumMetric{
- Aggregation: "cumulative",
- Monotonic: true,
- ValueType: "double",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".1",
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "2_scalar_metrics_sum_cumulative_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Simple scalar scrape creates int delta non-monotonic sum metric (3)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- clientSNMPData := SNMPData{
- oid: ".1",
- value: int64(1),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", mock.Anything, mock.Anything).Return([]SNMPData{clientSNMPData})
- scraper := &snmpScraper{
- cfg: &Config{
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Sum: &SumMetric{
- Aggregation: "delta",
- Monotonic: false,
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".1",
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "3_scalar_metrics_sum_delta_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Scalar scrape creates multiple metrics (4)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData1 := SNMPData{
- oid: ".1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData2 := SNMPData{
- oid: ".2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData1, snmpData2})
- scraper := &snmpScraper{
- cfg: &Config{
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".1",
- },
- },
- },
- "metric2": {
- Description: "test description2",
- Unit: "{things}",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".2",
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "4_scalar_multiple_metrics_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Scalar scrape creates metric with attributes (5)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- clientSNMPData := SNMPData{
- oid: ".1",
- value: int64(1),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", mock.Anything, mock.Anything).Return([]SNMPData{clientSNMPData})
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- Enum: []string{"val1", "val2"},
- },
- "attr2": {
- Value: "attr2NewName",
- Enum: []string{"val1", "val2"},
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- Value: "val1",
- },
- {
- Name: "attr2",
- Value: "val2",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "5_scalar_metric_w_attr_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Scalar scrape creates metric with multiple data points (6)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData1 := SNMPData{
- oid: ".1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData2 := SNMPData{
- oid: ".2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData1, snmpData2})
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- Enum: []string{"val1", "val2"},
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- Value: "val1",
- },
- },
- },
- {
- OID: ".2",
- Attributes: []Attribute{
- {
- Name: "attr1",
- Value: "val2",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "6_scalar_metric_w_multi_datapoint_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Indexed scrape errors and no scalar metric configs adds error",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- clientErr := errors.New("problem getting data")
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Run(
- func(args mock.Arguments) {
- scraperErrors := args.Get(1).(*scrapererror.ScrapeErrors)
- scraperErrors.AddPartial(1, clientErr)
- },
- ).Return([]SNMPData{})
- scraper := &snmpScraper{
- cfg: &Config{
- Metrics: map[string]*MetricConfig{
- "metric1": {
- ColumnOIDs: []ColumnOID{
- {
- OID: "1",
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- metrics, err := scraper.scrape(context.Background())
- require.EqualError(t, err, clientErr.Error())
- require.Equal(t, metrics.MetricCount(), 0)
- },
- },
- {
- desc: "Indexed metric scrape returns string data does not create metric",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- columnOID := ".1"
- oid1 := ".1.1"
- oid2 := ".1.2"
- snmpData1 := SNMPData{
- columnOID: columnOID,
- oid: oid1,
- value: "test1",
- valueType: stringVal,
- }
- snmpData2 := SNMPData{
- columnOID: columnOID,
- oid: oid2,
- value: "test2",
- valueType: stringVal,
- }
- innerError1 := fmt.Errorf(errMsgBadValueType, oid1)
- expectedScrapeErr1 := fmt.Errorf(errMsgIndexedMetricOIDProcessing, oid1, columnOID, innerError1)
- innerError2 := fmt.Errorf(errMsgBadValueType, oid2)
- expectedScrapeErr2 := fmt.Errorf(errMsgIndexedMetricOIDProcessing, oid2, columnOID, innerError2)
- expectedScrapeErrMsg := expectedScrapeErr1.Error() + "; " + expectedScrapeErr2.Error()
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData1, snmpData2})
- scraper := &snmpScraper{
- cfg: &Config{
- Metrics: map[string]*MetricConfig{
- "metric1": {
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- metrics, err := scraper.scrape(context.Background())
- require.EqualError(t, err, expectedScrapeErrMsg)
- require.Equal(t, metrics.MetricCount(), 0)
- },
- },
- {
- desc: "Simple indexed metric scrape creates int gauge metric on new no attribute resource (7)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData1 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData1, snmpData2})
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- IndexedValuePrefix: "attrPrefix",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "7_indexed_metrics_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Simple indexed metric scrape with non '.' prefixed OID still creates metric (7)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData1 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData1, snmpData2})
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- IndexedValuePrefix: "attrPrefix",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: "1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "7_indexed_metrics_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Simple indexed metric scrape creates float cumulative monotonic sum metric (8)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData1 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: float64(1.0),
- valueType: floatVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: float64(2.0),
- valueType: floatVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData1, snmpData2})
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- IndexedValuePrefix: "attrPrefix",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Sum: &SumMetric{
- Aggregation: "cumulative",
- Monotonic: true,
- ValueType: "double",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "8_indexed_metrics_sum_cumulative_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Simple indexed metric scrape creates int delta non-monotonic sum metric (9)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData1 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData1, snmpData2})
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- IndexedValuePrefix: "attrPrefix",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Sum: &SumMetric{
- Aggregation: "delta",
- Monotonic: false,
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "9_indexed_metrics_sum_delta_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Indexed metric scrape creates metric on existing resource if scalar metrics were scraped (10)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData0 := SNMPData{
- oid: ".0",
- value: int64(0),
- valueType: integerVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData0})
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData1, snmpData2})
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- IndexedValuePrefix: "attrPrefix",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric0": {
- Description: "test description0",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".0",
- },
- },
- },
- "metric1": {
- Description: "test description1",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "10_indexed_scalar_metrics_same_resource_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Indexed metric scrape creates multiple metrics on same no attribute resource (11)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData0 := SNMPData{
- columnOID: ".0",
- oid: ".0.1",
- value: int64(0),
- valueType: integerVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".0",
- oid: ".0.2",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(2),
- valueType: integerVal,
- }
- snmpData3 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(3),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData0, snmpData1, snmpData2, snmpData3})
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- IndexedValuePrefix: "attrPrefix",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric0": {
- Description: "test description0",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".0",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- "metric1": {
- Description: "test description1",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "11_indexed_multiple_metrics_same_resource_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Indexed metric scrape creates with all attribute config creates metric with all attributes (12)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData0 := SNMPData{
- columnOID: ".0",
- oid: ".0.1",
- value: "thing1",
- valueType: stringVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".0",
- oid: ".0.2",
- value: "thing2",
- valueType: stringVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData3 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", []string{".0"}, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- mockClient.On("GetIndexedData", []string{".1"}, mock.Anything).Return([]SNMPData{snmpData2, snmpData3}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- IndexedValuePrefix: "attrPrefix",
- },
- "attr2": {
- Value: "attr2NewName",
- Enum: []string{"val1", "val2"},
- },
- "attr3": {
- OID: ".0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- {
- Name: "attr2",
- Value: "val2",
- },
- {
- Name: "attr3",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "12_indexed_metrics_w_all_attrs_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Indexed attribute scrape error does not create metric datapoints",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- clientErr := errors.New("problem getting data")
- columnOID := ".1"
- oid1 := ".1.1"
- oid2 := ".1.2"
- snmpData0 := SNMPData{
- columnOID: columnOID,
- oid: oid1,
- value: int64(1),
- valueType: integerVal,
- }
- snmpData1 := SNMPData{
- columnOID: columnOID,
- oid: oid2,
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Run(
- func(args mock.Arguments) {
- scraperErrors := args.Get(1).(*scrapererror.ScrapeErrors)
- scraperErrors.AddPartial(1, clientErr)
- },
- ).Return([]SNMPData{}).Once()
- metricName := "metric1"
- innerInnerErr := errors.New(errMsgAttributeEmptyValue)
- innerErr := fmt.Errorf(errMsgOIDAttributeEmptyValue, metricName, innerInnerErr)
- expectedErr1 := fmt.Errorf(errMsgIndexedMetricOIDProcessing, oid1, columnOID, innerErr)
- expectedErr2 := fmt.Errorf(errMsgIndexedMetricOIDProcessing, oid2, columnOID, innerErr)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- OID: ".0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- metrics, err := scraper.scrape(context.Background())
- require.EqualError(t, err, fmt.Sprintf("%s; %s; %s", clientErr, expectedErr1, expectedErr2))
- require.Equal(t, metrics.MetricCount(), 0)
- },
- },
- {
- desc: "Indexed attribute scrape returning bad value type does not create metric data points",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- columnOID1 := ".0"
- columnOID2 := ".1"
- oid1 := ".0.1"
- oid2 := ".0.2"
- oid3 := ".1.1"
- oid4 := ".1.2"
- metricName := "metric1"
- snmpData0 := SNMPData{
- columnOID: columnOID1,
- oid: oid1,
- value: true,
- valueType: notSupportedVal,
- }
- snmpData1 := SNMPData{
- columnOID: columnOID1,
- oid: oid2,
- value: false,
- valueType: notSupportedVal,
- }
- snmpData2 := SNMPData{
- columnOID: columnOID2,
- oid: oid3,
- value: int64(1),
- valueType: integerVal,
- }
- snmpData3 := SNMPData{
- columnOID: columnOID2,
- oid: oid4,
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- innerErr1 := fmt.Errorf(errMsgIndexedAttributesBadValueType, oid1, columnOID1)
- expectedErr1 := fmt.Errorf(errMsgIndexedAttributeOIDProcessing, oid1, columnOID1, innerErr1)
- innerErr2 := fmt.Errorf(errMsgIndexedAttributesBadValueType, oid2, columnOID1)
- expectedErr2 := fmt.Errorf(errMsgIndexedAttributeOIDProcessing, oid2, columnOID1, innerErr2)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- innerInnerErr := errors.New(errMsgAttributeEmptyValue)
- innerErr := fmt.Errorf(errMsgOIDAttributeEmptyValue, metricName, innerInnerErr)
- expectedErr3 := fmt.Errorf(errMsgIndexedMetricOIDProcessing, oid3, columnOID2, innerErr)
- expectedErr4 := fmt.Errorf(errMsgIndexedMetricOIDProcessing, oid4, columnOID2, innerErr)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData2, snmpData3}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- OID: ".0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- metrics, err := scraper.scrape(context.Background())
- require.EqualError(t, err, fmt.Sprintf("%s; %s; %s; %s", expectedErr1, expectedErr2, expectedErr3, expectedErr4))
- require.Equal(t, metrics.MetricCount(), 0)
- },
- },
- {
- desc: "Indexed scrape for metric and attributes creates a metric with indexed attributes (13)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData0 := SNMPData{
- columnOID: ".0",
- oid: ".0.1",
- value: "thing1",
- valueType: stringVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".0",
- oid: ".0.2",
- value: "thing2",
- valueType: stringVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData3 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData2, snmpData3}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- OID: ".0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "13_indexed_metrics_w_column_oid_attr_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Indexed metric scrape with non '.' prefixed OID for attribute still creates metric (13)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData0 := SNMPData{
- columnOID: ".0",
- oid: ".0.1",
- value: "thing1",
- valueType: stringVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".0",
- oid: ".0.2",
- value: "thing2",
- valueType: stringVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData3 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", []string{".0"}, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- mockClient.On("GetIndexedData", []string{".1"}, mock.Anything).Return([]SNMPData{snmpData2, snmpData3}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- OID: "0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: "1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "13_indexed_metrics_w_column_oid_attr_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "SNMP float value for indexed attribute still creates metric (14)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData0 := SNMPData{
- columnOID: ".0",
- oid: ".0.1",
- value: 1.11111111,
- valueType: floatVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".0",
- oid: ".0.2",
- value: 2.22222222,
- valueType: floatVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData3 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", []string{".0"}, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- mockClient.On("GetIndexedData", []string{".1"}, mock.Anything).Return([]SNMPData{snmpData2, snmpData3}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- OID: ".0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "14_indexed_column_oid_float_attr_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "SNMP integer value for indexed attribute still creates metric (15)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData0 := SNMPData{
- columnOID: ".0",
- oid: ".0.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".0",
- oid: ".0.2",
- value: int64(2),
- valueType: integerVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData3 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", []string{".0"}, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- mockClient.On("GetIndexedData", []string{".1"}, mock.Anything).Return([]SNMPData{snmpData2, snmpData3}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- OID: ".0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "15_indexed_column_oid_int_attr_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Resource attribute with prefix creates new resources with created metrics (16)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData0 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".2",
- oid: ".2.1",
- value: float64(1.0),
- valueType: floatVal,
- }
- snmpData3 := SNMPData{
- columnOID: ".2",
- oid: ".2.2",
- value: float64(2.0),
- valueType: floatVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData0, snmpData1, snmpData2, snmpData3})
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- IndexedValuePrefix: "thing",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- ResourceAttributes: []string{"rattr1"},
- },
- },
- },
- "metric2": {
- Description: "test description2",
- Unit: "{units}",
- Gauge: &GaugeMetric{
- ValueType: "double",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".2",
- ResourceAttributes: []string{"rattr1"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "16_indexed_prefix_res_attr_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Indexed resource attribute scrape error will not create metrics or resources",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- clientErr := errors.New("problem getting data")
- columnOID := ".1"
- oid1 := ".1.1"
- oid2 := ".1.2"
- metricName := "metric1"
- snmpData0 := SNMPData{
- columnOID: columnOID,
- oid: oid1,
- value: int64(1),
- valueType: integerVal,
- }
- snmpData1 := SNMPData{
- columnOID: columnOID,
- oid: oid2,
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", []string{".0"}, mock.Anything).Run(
- func(args mock.Arguments) {
- scraperErrors := args.Get(1).(*scrapererror.ScrapeErrors)
- scraperErrors.AddPartial(1, clientErr)
- },
- ).Return([]SNMPData{}).Once()
- innerInnerErr := errors.New(errMsgResourceAttributeEmptyValue)
- innerErr := fmt.Errorf(errMsgOIDResourceAttributeEmptyValue, metricName, innerInnerErr)
- expectedErr1 := fmt.Errorf(errMsgIndexedMetricOIDProcessing, oid1, columnOID, innerErr)
- expectedErr2 := fmt.Errorf(errMsgIndexedMetricOIDProcessing, oid2, columnOID, innerErr)
- mockClient.On("GetIndexedData", []string{".1"}, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- OID: ".0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- ResourceAttributes: []string{"rattr1"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- metrics, err := scraper.scrape(context.Background())
- require.EqualError(t, err, fmt.Sprintf("%s; %s; %s", clientErr, expectedErr1, expectedErr2))
- require.Equal(t, metrics.MetricCount(), 0)
- },
- },
- {
- desc: "Indexed resource attribute scrape returning bad value type will not create metrics or resources",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- columnOID1 := ".0"
- columnOID2 := ".1"
- oid1 := ".0.1"
- oid2 := ".0.2"
- oid3 := ".1.1"
- oid4 := ".1.2"
- metricName := "metric1"
- snmpData0 := SNMPData{
- columnOID: ".0",
- oid: ".0.1",
- value: true,
- valueType: notSupportedVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".0",
- oid: ".0.2",
- value: false,
- valueType: notSupportedVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData3 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- innerErr1 := fmt.Errorf(errMsgIndexedAttributesBadValueType, oid1, columnOID1)
- expectedErr1 := fmt.Errorf(errMsgIndexedAttributeOIDProcessing, oid1, columnOID1, innerErr1)
- innerErr2 := fmt.Errorf(errMsgIndexedAttributesBadValueType, oid2, columnOID1)
- expectedErr2 := fmt.Errorf(errMsgIndexedAttributeOIDProcessing, oid2, columnOID1, innerErr2)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- innerInnerErr := errors.New(errMsgResourceAttributeEmptyValue)
- innerErr := fmt.Errorf(errMsgOIDResourceAttributeEmptyValue, metricName, innerInnerErr)
- expectedErr3 := fmt.Errorf(errMsgIndexedMetricOIDProcessing, oid3, columnOID2, innerErr)
- expectedErr4 := fmt.Errorf(errMsgIndexedMetricOIDProcessing, oid4, columnOID2, innerErr)
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData2, snmpData3}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- OID: ".0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- ResourceAttributes: []string{"rattr1"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- metrics, err := scraper.scrape(context.Background())
- require.EqualError(t, err, fmt.Sprintf("%s; %s; %s; %s", expectedErr1, expectedErr2, expectedErr3, expectedErr4))
- require.Equal(t, metrics.MetricCount(), 0)
- },
- },
- {
- desc: "Resource attribute with column OID creates new resource with multiple metrics (17)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData0 := SNMPData{
- columnOID: ".0",
- oid: ".0.1",
- value: "thing1",
- valueType: stringVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".0",
- oid: ".0.2",
- value: "thing2",
- valueType: stringVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData3 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- snmpData4 := SNMPData{
- columnOID: ".2",
- oid: ".2.1",
- value: float64(1.0),
- valueType: floatVal,
- }
- snmpData5 := SNMPData{
- columnOID: ".2",
- oid: ".2.2",
- value: float64(2.0),
- valueType: floatVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", []string{".0"}, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData2, snmpData3, snmpData4, snmpData5}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- OID: ".0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- ResourceAttributes: []string{"rattr1"},
- },
- },
- },
- "metric2": {
- Description: "test description2",
- Unit: "{units}",
- Gauge: &GaugeMetric{
- ValueType: "double",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".2",
- ResourceAttributes: []string{"rattr1"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "17_indexed_oid_res_attr_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Resource attribute with column OID without . prefix still creates metrics (17)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData0 := SNMPData{
- columnOID: ".0",
- oid: ".0.1",
- value: "thing1",
- valueType: stringVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".0",
- oid: ".0.2",
- value: "thing2",
- valueType: stringVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData3 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- snmpData4 := SNMPData{
- columnOID: ".2",
- oid: ".2.1",
- value: float64(1.0),
- valueType: floatVal,
- }
- snmpData5 := SNMPData{
- columnOID: ".2",
- oid: ".2.2",
- value: float64(2.0),
- valueType: floatVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", []string{".0"}, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- mockClient.On("GetIndexedData", mock.Anything, mock.Anything).Return([]SNMPData{snmpData2, snmpData3, snmpData4, snmpData5}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- OID: "0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: "1",
- ResourceAttributes: []string{"rattr1"},
- },
- },
- },
- "metric2": {
- Description: "test description2",
- Unit: "{units}",
- Gauge: &GaugeMetric{
- ValueType: "double",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: "2",
- ResourceAttributes: []string{"rattr1"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "17_indexed_oid_res_attr_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Indexed config with both column OID and prefix resource attributes creates metric (18)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- snmpData0 := SNMPData{
- columnOID: ".0",
- oid: ".0.1",
- value: "thing1",
- valueType: stringVal,
- }
- snmpData1 := SNMPData{
- columnOID: ".0",
- oid: ".0.2",
- value: "thing2",
- valueType: stringVal,
- }
- snmpData2 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- snmpData3 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetIndexedData", []string{".0"}, mock.Anything).Return([]SNMPData{snmpData0, snmpData1}).Once()
- mockClient.On("GetIndexedData", []string{".1"}, mock.Anything).Return([]SNMPData{snmpData2, snmpData3}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- OID: ".0",
- },
- "rattr2": {
- IndexedValuePrefix: "object",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".1",
- ResourceAttributes: []string{"rattr1", "rattr2"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics",
- "18_indexed_oid_and_prefix_res_attr_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "ScalarOID (string) resource attribute attached to ColumnOID metric alongside a ColumnOID (string) resource attribute creates metric (19)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- scalarRA := SNMPData{
- oid: ".0",
- value: "scalar",
- valueType: stringVal,
- }
- coidRA11 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: "string1",
- valueType: stringVal,
- }
- coidRA12 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: "string2",
- valueType: stringVal,
- }
- coid21 := SNMPData{
- columnOID: ".2",
- oid: ".2.1",
- value: int64(3),
- valueType: integerVal,
- }
- coid22 := SNMPData{
- columnOID: ".2",
- oid: ".2.2",
- value: int64(4),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", []string{".0"}, mock.Anything).Return([]SNMPData{scalarRA}).Once()
- mockClient.On("GetIndexedData", []string{".1"}, mock.Anything).Return([]SNMPData{coidRA11, coidRA12}).Once()
- mockClient.On("GetIndexedData", []string{".2"}, mock.Anything).Return([]SNMPData{coid21, coid22}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- ScalarOID: ".0",
- },
- "rattr2": {
- OID: ".1",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".2",
- ResourceAttributes: []string{"rattr1", "rattr2"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "19_scalar_ra_string_and_coid_ra_string_on_coid_metric_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "ScalarOID (int) resource attribute attached to ColumnOID metric alongside a ColumnOID (int) resource attribute creates metric (20)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- scalarRA := SNMPData{
- oid: ".0",
- value: int64(5),
- valueType: integerVal,
- }
- coidRA11 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: int64(1),
- valueType: integerVal,
- }
- coidRA12 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: int64(2),
- valueType: integerVal,
- }
- coid21 := SNMPData{
- columnOID: ".2",
- oid: ".2.1",
- value: int64(3),
- valueType: integerVal,
- }
- coid22 := SNMPData{
- columnOID: ".2",
- oid: ".2.2",
- value: int64(4),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", []string{".0"}, mock.Anything).Return([]SNMPData{scalarRA}).Once()
- mockClient.On("GetIndexedData", []string{".1"}, mock.Anything).Return([]SNMPData{coidRA11, coidRA12}).Once()
- mockClient.On("GetIndexedData", []string{".2"}, mock.Anything).Return([]SNMPData{coid21, coid22}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- ScalarOID: ".0",
- },
- "rattr2": {
- OID: ".1",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".2",
- ResourceAttributes: []string{"rattr1", "rattr2"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "20_scalar_ra_int_and_coid_ra_int_on_coid_metric_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "ScalarOID (float) resource attribute attached to ColumnOID metric alongside a ColumnOID (float) resource attribute creates metric (21)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- scalarRA := SNMPData{
- oid: ".0",
- value: float64(5.0),
- valueType: floatVal,
- }
- coidRA11 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: float64(1.0),
- valueType: floatVal,
- }
- coidRA12 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: float64(2.0),
- valueType: floatVal,
- }
- coid21 := SNMPData{
- columnOID: ".2",
- oid: ".2.1",
- value: int64(3),
- valueType: integerVal,
- }
- coid22 := SNMPData{
- columnOID: ".2",
- oid: ".2.2",
- value: int64(4),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", []string{".0"}, mock.Anything).Return([]SNMPData{scalarRA}).Once()
- mockClient.On("GetIndexedData", []string{".1"}, mock.Anything).Return([]SNMPData{coidRA11, coidRA12}).Once()
- mockClient.On("GetIndexedData", []string{".2"}, mock.Anything).Return([]SNMPData{coid21, coid22}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- ScalarOID: ".0",
- },
- "rattr2": {
- OID: ".1",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".2",
- ResourceAttributes: []string{"rattr1", "rattr2"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "21_scalar_ra_float_and_coid_ra_float_on_coid_metric_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "ScalarOID (string) resource attribute attached to ColumnOID metric alongside an IndexedValuePrefix resource attribute creates metric (22)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- scalarRA := SNMPData{
- oid: ".0",
- value: "scalar",
- valueType: stringVal,
- }
- coid21 := SNMPData{
- columnOID: ".2",
- oid: ".2.1",
- value: int64(3),
- valueType: integerVal,
- }
- coid22 := SNMPData{
- columnOID: ".2",
- oid: ".2.2",
- value: int64(4),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", []string{".0"}, mock.Anything).Return([]SNMPData{scalarRA}).Once()
- mockClient.On("GetIndexedData", []string{".2"}, mock.Anything).Return([]SNMPData{coid21, coid22}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- ScalarOID: ".0",
- },
- "rattr2": {
- IndexedValuePrefix: "p",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".2",
- ResourceAttributes: []string{"rattr1", "rattr2"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "22_scalar_ra_string_and_prefix_ra_on_coid_metric_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Multiple ScalarOID (string) resource attributes attached to ColumnOID metric alongside multiple Column OID (string) resource attributes creates metrics (23)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- scalarRA1 := SNMPData{
- oid: ".5.0",
- value: "scalar",
- valueType: stringVal,
- }
- scalarRA2 := SNMPData{
- oid: ".6.0",
- value: "also scalar",
- valueType: stringVal,
- }
- coidRA11 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: "string1",
- valueType: stringVal,
- }
- coidRA12 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: "string2",
- valueType: stringVal,
- }
- coidRA21 := SNMPData{
- columnOID: ".2",
- oid: ".2.1",
- value: "also a string1",
- valueType: stringVal,
- }
- coidRA22 := SNMPData{
- columnOID: ".2",
- oid: ".2.2",
- value: "also a string2",
- valueType: stringVal,
- }
- coid31 := SNMPData{
- columnOID: ".3",
- oid: ".3.1",
- value: int64(3),
- valueType: integerVal,
- }
- coid32 := SNMPData{
- columnOID: ".3",
- oid: ".3.2",
- value: int64(4),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", []string{".5.0", ".6.0"}, mock.Anything).Return([]SNMPData{scalarRA1, scalarRA2}).Once()
- mockClient.On("GetIndexedData", []string{".1", ".2"}, mock.Anything).Return([]SNMPData{coidRA11, coidRA12, coidRA21, coidRA22}).Once()
- mockClient.On("GetIndexedData", []string{".3"}, mock.Anything).Return([]SNMPData{coid31, coid32}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- ScalarOID: ".5.0",
- },
- "rattr2": {
- ScalarOID: ".6.0",
- },
- "rattr3": {
- OID: ".1",
- },
- "rattr4": {
- OID: ".2",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".3",
- ResourceAttributes: []string{"rattr1", "rattr2", "rattr3", "rattr4"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "23_multiple_scalar_oid_string_with_multiple_coid_ra_string_on_coid_metric_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "ScalarOID (string) resource attribute attached to ColumnOID metric alongside a ColumnOID (string) attribute creates metric (24)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- scalarRA := SNMPData{
- oid: ".0",
- value: "scalar",
- valueType: stringVal,
- }
- coidAttr11 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: "string1",
- valueType: stringVal,
- }
- coidAttr12 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: "string2",
- valueType: stringVal,
- }
- coid21 := SNMPData{
- columnOID: ".2",
- oid: ".2.1",
- value: int64(3),
- valueType: integerVal,
- }
- coid22 := SNMPData{
- columnOID: ".2",
- oid: ".2.2",
- value: int64(4),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", []string{".0"}, mock.Anything).Return([]SNMPData{scalarRA}).Once()
- mockClient.On("GetIndexedData", []string{".1"}, mock.Anything).Return([]SNMPData{coidAttr11, coidAttr12}).Once()
- mockClient.On("GetIndexedData", []string{".2"}, mock.Anything).Return([]SNMPData{coid21, coid22}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- ScalarOID: ".0",
- },
- },
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- OID: ".1",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".2",
- ResourceAttributes: []string{"rattr1"},
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "24_scalar_ra_string_and_coid_attr_string_on_coid_metric_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "ScalarOID (string) resource attribute attached to ColumnOID metric alongside an Indexed Value Prefix attribute creates metric (25)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- scalarRA := SNMPData{
- oid: ".0",
- value: "scalar",
- valueType: stringVal,
- }
- coid21 := SNMPData{
- columnOID: ".2",
- oid: ".2.1",
- value: int64(3),
- valueType: integerVal,
- }
- coid22 := SNMPData{
- columnOID: ".2",
- oid: ".2.2",
- value: int64(4),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", []string{".0"}, mock.Anything).Return([]SNMPData{scalarRA}).Once()
- mockClient.On("GetIndexedData", []string{".2"}, mock.Anything).Return([]SNMPData{coid21, coid22}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- ScalarOID: ".0",
- },
- },
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- IndexedValuePrefix: "prefix",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".2",
- ResourceAttributes: []string{"rattr1"},
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "25_scalar_ra_string_and_ivp_attr_on_coid_metric_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "ScalarOID (string) resource attribute attached to ScalarOID metric creates metric (26)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- scalarRA := SNMPData{
- oid: ".5.0",
- value: "scalar",
- valueType: stringVal,
- }
- scalarOID := SNMPData{
- oid: ".6.0",
- value: int64(6),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", []string{".5.0"}, mock.Anything).Return([]SNMPData{scalarRA}).Once()
- mockClient.On("GetScalarData", []string{".6.0"}, mock.Anything).Return([]SNMPData{scalarOID}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- ScalarOID: ".5.0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".6.0",
- ResourceAttributes: []string{"rattr1"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "26_scalar_ra_string_on_scalar_metric_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Multiple ScalarOID (string) resource attributes attached to ScalarOID metric creates single resource for metric (27)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- scalarRA1 := SNMPData{
- oid: ".5.0",
- value: "scalar",
- valueType: stringVal,
- }
- scalarRA2 := SNMPData{
- oid: ".7.0",
- value: "also scalar",
- valueType: stringVal,
- }
- scalarOID := SNMPData{
- oid: ".6.0",
- value: int64(6),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", []string{".5.0", ".7.0"}, mock.Anything).Return([]SNMPData{scalarRA1, scalarRA2}).Once()
- mockClient.On("GetScalarData", []string{".6.0"}, mock.Anything).Return([]SNMPData{scalarOID}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- ScalarOID: ".5.0",
- },
- "rattr2": {
- ScalarOID: ".7.0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".6.0",
- ResourceAttributes: []string{"rattr1", "rattr2"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "27_multiple_scalar_ra_string_on_scalar_metric_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Two scalar oid metrics with the same resource attribute get added to a single resource (28)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- scalarRA := SNMPData{
- oid: ".5.0",
- value: "scalar",
- valueType: stringVal,
- }
- scalarOID1 := SNMPData{
- oid: ".6.0",
- value: int64(6),
- valueType: integerVal,
- }
- scalarOID2 := SNMPData{
- oid: ".7.0",
- value: int64(7),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", []string{".5.0"}, mock.Anything).Return([]SNMPData{scalarRA}).Once()
- mockClient.On("GetScalarData", []string{".6.0", ".7.0"}, mock.Anything).Return([]SNMPData{scalarOID1, scalarOID2}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- ScalarOID: ".5.0",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".6.0",
- ResourceAttributes: []string{"rattr1"},
- },
- },
- },
- "metric2": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ScalarOIDs: []ScalarOID{
- {
- OID: ".7.0",
- ResourceAttributes: []string{"rattr1"},
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "28_two_scalar_oid_metrics_with_same_resource_attribute_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- {
- desc: "Metric does not use all available scalar RAs and still behaves properly (near copy of (24)) (29)",
- testFunc: func(t *testing.T) {
- mockClient := new(MockClient)
- scalarRA1 := SNMPData{
- oid: ".5.0",
- value: "scalar",
- valueType: stringVal,
- }
- scalarRA2 := SNMPData{
- oid: ".6.0",
- value: "also scalar",
- valueType: stringVal,
- }
- coidAttr11 := SNMPData{
- columnOID: ".1",
- oid: ".1.1",
- value: "string1",
- valueType: stringVal,
- }
- coidAttr12 := SNMPData{
- columnOID: ".1",
- oid: ".1.2",
- value: "string2",
- valueType: stringVal,
- }
- coid21 := SNMPData{
- columnOID: ".2",
- oid: ".2.1",
- value: int64(3),
- valueType: integerVal,
- }
- coid22 := SNMPData{
- columnOID: ".2",
- oid: ".2.2",
- value: int64(4),
- valueType: integerVal,
- }
- mockClient.On("Connect").Return(nil)
- mockClient.On("Close").Return(nil)
- mockClient.On("GetScalarData", []string{".5.0", ".6.0"}, mock.Anything).Return([]SNMPData{scalarRA1, scalarRA2}).Once()
- mockClient.On("GetIndexedData", []string{".1"}, mock.Anything).Return([]SNMPData{coidAttr11, coidAttr12}).Once()
- mockClient.On("GetIndexedData", []string{".2"}, mock.Anything).Return([]SNMPData{coid21, coid22}).Once()
- scraper := &snmpScraper{
- cfg: &Config{
- ResourceAttributes: map[string]*ResourceAttributeConfig{
- "rattr1": {
- ScalarOID: ".5.0",
- },
- "rattr2": {
- ScalarOID: ".6.0",
- },
- },
- Attributes: map[string]*AttributeConfig{
- "attr1": {
- OID: ".1",
- },
- },
- Metrics: map[string]*MetricConfig{
- "metric1": {
- Description: "test description",
- Unit: "By",
- Gauge: &GaugeMetric{
- ValueType: "int",
- },
- ColumnOIDs: []ColumnOID{
- {
- OID: ".2",
- ResourceAttributes: []string{"rattr1"},
- Attributes: []Attribute{
- {
- Name: "attr1",
- },
- },
- },
- },
- },
- },
- },
- settings: receivertest.NewNopCreateSettings(),
- client: mockClient,
- logger: zap.NewNop(),
- }
- expectedMetricGen := func(t *testing.T) pmetric.Metrics {
- goldenPath := filepath.Join("testdata", "expected_metrics", "29_metric_does_not_use_all_available_scalar_RAs_golden.yaml")
- expectedMetrics, err := golden.ReadMetrics(goldenPath)
- require.NoError(t, err)
- return expectedMetrics
- }
- expectedMetrics := expectedMetricGen(t)
- metrics, err := scraper.scrape(context.Background())
- require.NoError(t, err)
- err = pmetrictest.CompareMetrics(expectedMetrics, metrics, pmetrictest.IgnoreTimestamp())
- require.NoError(t, err)
- },
- },
- }
- for _, tc := range testCases {
- t.Run(tc.desc, tc.testFunc)
- }
- }
|